Rob Funk <rfunk(_at_)funknet(_dot_)net>:
Is it an appropriate to make a change like this? Is the patch well formed?
Is the keyword addition appropriate? etc.
I think ESR usually tries to avoid adding keywords. This case in
particular appears superfluous to me.
Rob is correct about my philosophy in the first, and I agree in the second.
I'm not sure what you mean by a well-formed patch, but since you
asked, it's generally considered best to use "unified diff" mode
("diff -u") when creating patches, if possible. But the "context
diff" mode ("diff -c") you appear to have used is a good second
Some maintainers prefer one, some the other. Either is generally
acceptable, but the default ed format is not.
<a href="http://www.tuxedo.org/~esr/">Eric S. Raymond</a>
In the absence of any evidence tending to show that possession
or use of a 'shotgun having a barrel of less than eighteen inches
in length' at this time has some reasonable relationship to the
preservation or efficiency of a well regulated militia, we cannot
say that the Second Amendment guarantees the right to keep and bear
such an instrument. [...] The Militia comprised all males
physically capable of acting in concert for the common defense.
-- Majority Supreme Court opinion in "U.S. vs. Miller" (1939)