procmail
[Top] [All Lists]

Re: Cyberpromo named boot - list of domains to filter.

1997-08-17 10:21:00

A couple comments on your recipes.  Nothing major, just some style
points.

Conrad Sabatier <conrads(_at_)neosoft(_dot_)com> writes:
# Make LINEBUF large enough so we don't choke on the file

LINEBUF=16384

Since you don't actually read the contents of the file into a variable,
this is not needed and will just slow procmail down.

...
:0 hir
* ?egrep -isFf $BLOCKDOM
/dev/null

Procmail automatically turns on the 'r' flag for deliveries to
/dev/null, so there's no need to do it yourself.  The 'i' flag is
useless for mailbox deliveries: it only affects '|' and '!' actions.

Finally, people thinking of using this should note that it requires a
POSIX compatible *grep for the 'F' option, which causes *grep to behave
like fgrep and search for fixed strings, not regexps.  Calling "egrep"
for this seems kinda obfuscutory.


Philip Guenther

<Prev in Thread] Current Thread [Next in Thread>