ietf
[Top] [All Lists]

RE: Gen-ART review of draft-ietf-pcp-upnp-igd-interworking-07

2013-04-11 10:03:21
Dear Peter,

The new version is now available online. A diff is available here: 
http://www.ietf.org/rfcdiff?url2=draft-ietf-pcp-upnp-igd-interworking-08.

Thank you again for the review.

Cheers,
Med

-----Message d'origine-----
De : Peter Yee [mailto:peter(_at_)akayla(_dot_)com]
Envoyé : mercredi 10 avril 2013 18:47
À : BOUCADAIR Mohamed OLNC/OLN; draft-ietf-pcp-upnp-igd-
interworking(_dot_)all(_at_)tools(_dot_)ietf(_dot_)org
Cc : gen-art(_at_)ietf(_dot_)org; ietf(_at_)ietf(_dot_)org
Objet : RE: Gen-ART review of draft-ietf-pcp-upnp-igd-interworking-07

Med,

      That looks great.  Thanks for accommodating my concern.

                      Kind regards,
                      -Peter

-----Original Message-----
From: mohamed(_dot_)boucadair(_at_)orange(_dot_)com 
[mailto:mohamed(_dot_)boucadair(_at_)orange(_dot_)com]
Sent: Wednesday, April 10, 2013 12:49 AM
To: Peter Yee; 
draft-ietf-pcp-upnp-igd-interworking(_dot_)all(_at_)tools(_dot_)ietf(_dot_)org
Cc: gen-art(_at_)ietf(_dot_)org; ietf(_at_)ietf(_dot_)org
Subject: RE: Gen-ART review of draft-ietf-pcp-upnp-igd-interworking-07

Dear Peter,

I changed the text as follows:

OLD:

  If the requested external port is not available, the PCP server will
  send a CANNOT_PROVIDE_EXTERNAL error response.  If a short lifetime
  error is returned, the IGD-PCP IWF MAY re-send the same request to
  the PCP Server after 30 seconds.  If a PCP error response is
  received, the IGD-PCP IWF relays a negative message to the UPnP
  Control Point with ConflictInMappingEntry as the error code.

NEW:

  If the requested external port is not available, the PCP server will
  send a CANNOT_PROVIDE_EXTERNAL error response:

  1.  If a short lifetime error is returned, the IGD-PCP IWF MAY resend
      the same request to the PCP Server after 30 seconds without
      relaying the error to the UPnP Control Point.  The IGD-PCP IWF
      MAY repeat this process until a positive answer is received or
      some maximum retry limit is reached.  When the maximum retry
      limit is reached, the IGD-PCP IWF relays a negative message to
      the UPnP Control Point with ConflictInMappingEntry as the error
      code.

  2.  If a long lifetime error is returned, the IGD-PCP IWF relays a
      negative message to the UPnP Control Point with
      ConflictInMappingEntry as the error code.

Better?

Cheers,
Med

-----Message d'origine-----
De : Peter Yee [mailto:peter(_at_)akayla(_dot_)com] Envoyé : mardi 9 avril 
2013
20:58 À : BOUCADAIR Mohamed OLNC/OLN; draft-ietf-pcp-upnp-igd-
interworking(_dot_)all(_at_)tools(_dot_)ietf(_dot_)org Cc : 
gen-art(_at_)ietf(_dot_)org; ietf(_at_)ietf(_dot_)org
Objet : RE: Gen-ART review of draft-ietf-pcp-upnp-igd-interworking-07

Med,
     Thanks for the swift response to my review.  See my one reply
inline.

             Kind regards,
             -Peter

Page 13, 1st paragraph, 3rd sentence: what's meant here is if any PCP
error other than a short-lifetime error, or in the case of a failed
resend, any PCP error at all.  The wording makes it seem like the
short-lifetime errors are somehow not PCP errors and is therefore
confusing.  It also doesn't explicitly deal with how many repeats
should
be done on a resend.

[Med] The basic behavior is to relay the received error to the UPnP CP.
For
the short-lifetime errors, the IWF may decide to resend the request and
not relay those errors immediately to the UPnP CP. The number of
repeats is not specified here as it can be implementation-specific.

Your explanation is fine.  I just found the wording "If a PCP  error
response is received" to sound ambiguously as if the short-lifetime
errors were not a subset of PCP errors.