mhonarc-dev

[bug #5905] Modification of non-creatable array value attempted

2003-10-17 15:21:40

=================== BUG #5905: LATEST MODIFICATIONS ==================
http://savannah.nongnu.org/bugs/?func=detailbug&bug_id=5905&group_id=1968

Changes by: Earl Hood <earl(_at_)earlhood(_dot_)com>
Date: Fri 10/17/2003 at 17:19 (US/Central)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Fixed
       Fixed Release |                           | CVS
                  CC |                           | 
lists(_at_)lhs(_dot_)com(_dot_)ar


------------------ Additional Follow-up Comments ----------------------------
Conversion of relative URLs to full URLs has been redone.
Since readmail.pl had a similiar function as in
mhtxthtml.pl, the readmail version was redone and
mhtxthtml.pl changed to use it.

The Perl error does no long occurs with provided sample
message, and the possibility of the error to occur should
be zero (famous last words) since argument to slice() is
checked beforehand.



=================== BUG #5905: FULL BUG SNAPSHOT ===================


Submitted by: ehood                   Project: MHonArc                      
Submitted on: Sun 10/12/2003 at 23:25
Category:  MIME Filter                Severity:  5 - Major                  
Bug Group:  Crash Error               Resolution:  Fixed                    
Assigned to:  None                    Status:  Open                         
Platform Version:  All                Perl Version:  All                    
Component Version:  <=2.6.8           Fixed Release:  CVS                   

Summary:  Modification of non-creatable array value attempted

Original Submission:  
(Problem initially reported by Franco Galian to the
 mhonarc-users list.)

For certain message types, the following Perl error message
is generated:

Modification of non-creatable array value attempted, 
subscript -2 at lib/mhtxthtml.pl line 376, <GEN0> line 27.

Franco has supplied sample message that re-creates the
problem via private mail.

Follow-up Comments
*******************

-------------------------------------------------------
Date: Fri 10/17/2003 at 17:19       By: ehood
Conversion of relative URLs to full URLs has been redone.
Since readmail.pl had a similiar function as in
mhtxthtml.pl, the readmail version was redone and
mhtxthtml.pl changed to use it.

The Perl error does no long occurs with provided sample
message, and the possibility of the error to occur should
be zero (famous last words) since argument to slice() is
checked beforehand.

-------------------------------------------------------
Date: Sun 10/12/2003 at 23:49       By: ehood
Initial analysis shows that problem occurs when the
base URL of an HTML message is determined to be just
the protocol string (e.g. "http://";) and nothing more
(btw, this problem could technically affect readmail.pl
also).

In the sample message, the base is computed to be
"file://" -- that's it.  Actually, the message uses
'' as path separator for the pathname compoent,
but that is not legal, and I have no desire to to deal
with it.  Therefore, mhtxthtml.pl computes the base
URL (from the <BASE> tag) to just be "file://".

Regardless, a decision needs to be made on how to handle
cases where the base URL is bogus, like "http://"; (no
hostname component is present).  At a minimum, the code
needs to so some integrity checks to avoid the Perl error
message.  Trying to validate the URL may be a pain since
it would require knowing all possible URL schemes.


CC List
*******

CC Address                          | Comment
------------------------------------+-----------------------------
lists(_at_)lhs(_dot_)com(_dot_)ar                    | 



No files currently attached


For detailed info, follow this link:
http://savannah.nongnu.org/bugs/?func=detailbug&bug_id=5905&group_id=1968

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/

---------------------------------------------------------------------
To sign-off this list, send email to majordomo(_at_)mhonarc(_dot_)org with the
message text UNSUBSCRIBE MHONARC-DEV

<Prev in Thread] Current Thread [Next in Thread>