nmh-workers
[Top] [All Lists]

Re: Patch for bug #3200 (with patch attached this time)

2003-06-28 13:30:04

Hi Jeffrey,

You should mail the comments directly to him:

      Jeffrey C Honig <jch(_at_)honig(_dot_)net>

Done.

+/*
+ * c_flags bits
+ */
+#define CF_TRUE        (1<<0) /* usually means component is present */
+#define CF_ADDRPARSED  (2<<0) /* address has been parsed */
+#define CF_DATEFAB     (3<<0) /* datefield fabricated */

This looks wrong.  Wouldn't 1, 2, and 4 be better values?

Also, can FNORD be called repeatedly, i.e. does it insert a separator?
It's definition didn't appear in the patch and I haven't the source to
hand.

Cheers,


Ralph.

<Prev in Thread] Current Thread [Next in Thread>