nmh-workers
[Top] [All Lists]

Re: [Nmh-workers] hardcoded Charset removal

2012-09-17 20:23:57
Yozo TODA wrote:

Hi, uip/mhparse.c contains Charset array, and only charsets included
in this array are realized in the mh-profile processing.

grep-ing files I found Charset is used only in uip/mhparse.c, and by
removing (the very small abount of) the related code nmh can
recognize any charset related directives in mh-profile.  attached
below is the patch to remove Charset related code.

h/mhparse.h includes CHARSET_LATIN and I believe it can be also removed.
the patch below does not touch h/mhparse.h.

any comments?

my motivation is the following;
    o I want to write directives mhshow-charset-iso-2022-jp,
mhshow-charset-shift_jis, etc
      in .mh_profile
    o I don't want to invoke another terminal window; I prefer to
convert the charset encoding
      (e.g., apply "iconv -f iso-2022-jp-2 -t utf-8" to contents)

Thank you for analyzing this and providing a patch.  I
have one question.  The patch removes the setting of
t->tx_charset.  Should we retain that?  It's used in
mhbuild, I believe.

If so, I think we'd want to keep what was there, but
not let chset get set to NULL.

David

_______________________________________________
Nmh-workers mailing list
Nmh-workers(_at_)nongnu(_dot_)org
https://lists.nongnu.org/mailman/listinfo/nmh-workers

<Prev in Thread] Current Thread [Next in Thread>