From linux-kernel-owner(_at_)vger(_dot_)kernel(_dot_)org Thu Mar 16 22:43:05 2017 Return-Path: Received: from turing-police.cc.vt.edu (turing-police.cc.vt.edu [IPv6:0:0:0:0:0:0:0:1]) by turing-police.cc.vt.edu (8.15.2/8.14.7) with ESMTP id v2H2gVsB003113 for ; Thu, 16 Mar 2017 22:43:05 -0400 Delivered-To: valdis(_at_)vt(_dot_)edu Received: from gmail-imap.l.google.com [2607:f8b0:400d:c0c::6c] by turing-police.cc.vt.edu with IMAP (fetchmail-6.3.26) for (single-drop); Thu, 16 Mar 2017 22:43:05 -0400 (EDT) Received: by 10.223.160.71 with SMTP id l7csp113256wrl; Thu, 16 Mar 2017 19:31:42 -0700 (PDT) X-Received: by 10.237.35.164 with SMTP id j33mr12150611qtc.194.1489717902270; Thu, 16 Mar 2017 19:31:42 -0700 (PDT) Received: from mr2.cc.vt.edu (mr2.cc.ipv6.vt.edu. [2607:b400:92:8400:0:90:e077:bf22]) by mx.google.com with ESMTPS id b47si5384817qtc.27.2017.03.16.19.31.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Mar 2017 19:31:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner(_at_)vger(_dot_)kernel(_dot_)org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner(_at_)vger(_dot_)kernel(_dot_)org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner(_at_)vger(_dot_)kernel(_dot_)org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mr2.cc.vt.edu (8.14.7/8.14.7) with ESMTP id v2H2VZme003825; Thu, 16 Mar 2017 22:31:41 -0400 Received: (majordomo(_at_)vger(_dot_)kernel(_dot_)org) by vger.kernel.org via listexpand id S1752794AbdCQCbQ (ORCPT + 1 other); Thu, 16 Mar 2017 22:31:16 -0400 Received: from regular1.263xmail.com ([211.150.99.132]:53989 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbdCQCbD (ORCPT ); Thu, 16 Mar 2017 22:31:03 -0400 Received: from cl?rock-chips.com (unknown [192.168.167.190]) by regular1.263xmail.com (Postfix) with ESMTP id 7A45B950F; Fri, 17 Mar 2017 10:26:51 +0800 (CST) X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 Received: from [172.16.12.65] (localhost [127.0.0.1]) by smtp.263.net (Postfix) with ESMTP id 60E214B8; Fri, 17 Mar 2017 10:25:58 +0800 (CST) X-RL-SENDER: cl(_at_)rock-chips(_dot_)com X-FST-TO: jic23(_at_)kernel(_dot_)org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: cl(_at_)rock-chips(_dot_)com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-SENDER: cl(_at_)rock-chips(_dot_)com X-DNS-TYPE: 0 Received: from [172.16.12.65] (unknown [58.22.7.114]) by smtp.263.net (Postfix) whith ESMTP id 71453YBI1R; Fri, 17 Mar 2017 10:26:05 +0800 (CST) Subject: Re: [PATCH v1 6/7] arm64: dts: rockchip: add dts file for RK3328 evaluation board To: Andre Przywara , heiko(_at_)sntech(_dot_)de References: <1489572237-6649-1-git-send-email-cl(_at_)rock-chips(_dot_)com> <1489628711-31271-1-git-send-email-cl(_at_)rock-chips(_dot_)com> <63969127-3fcd-658c-2986-8ded6d93c433(_at_)arm(_dot_)com> Cc: mark(_dot_)rutland(_at_)arm(_dot_)com, wsa(_at_)the-dreams(_dot_)de, linux-iio(_at_)vger(_dot_)kernel(_dot_)org, catalin(_dot_)marinas(_at_)arm(_dot_)com, shawn(_dot_)lin(_at_)rock-chips(_dot_)com, will(_dot_)deacon(_at_)arm(_dot_)com, kever(_dot_)yang(_at_)rock-chips(_dot_)com, dianders(_at_)chromium(_dot_)org, yamada(_dot_)masahiro(_at_)socionext(_dot_)com, tony(_dot_)xie(_at_)rock-chips(_dot_)com, linux-i2c(_at_)vger(_dot_)kernel(_dot_)org, pmeerw(_at_)pmeerw(_dot_)net, lars(_at_)metafoo(_dot_)de, zhengxing(_at_)rock-chips(_dot_)com, khilman(_at_)baylibre(_dot_)com, linux-rockchip(_at_)lists(_dot_)infradead(_dot_)org, jay(_dot_)xu(_at_)rock-chips(_dot_)com, wxt(_at_)rock-chips(_dot_)com, huangtao(_at_)rock-chips(_dot_)com, devicetree(_at_)vger(_dot_)kernel(_dot_)org, zhangqing(_at_)rock-chips(_dot_)com, paweljarosz3691(_at_)gmail(_dot_)com, arnd(_at_)arndb(_dot_)de, yhx(_at_)rock-chips(_dot_)com, knaack(_dot_)h(_at_)gmx(_dot_)de, robh+dt(_at_)kernel(_dot_)org, matthias(_dot_)bgg(_at_)gmail(_dot_)com, rocky(_dot_)hao(_at_)rock-chips(_dot_)com, linux-arm-kernel(_at_)lists(_dot_)infradead(_dot_)org, linux-kernel(_at_)vger(_dot_)kernel(_dot_)org, david(_dot_)wu(_at_)rock-chips(_dot_)com, fabio(_dot_)estevam(_at_)nxp(_dot_)com, andy(_dot_)yan(_at_)rock-chips(_dot_)com, akpm(_at_)linux-foundation(_dot_)org, shawnguo(_at_)kernel(_dot_)org, afaerber(_at_)suse(_dot_)de, jic23(_at_)kernel(_dot_)org From: =?UTF-8?B?6ZmI5Lqu?= Message-ID: <58CB4945(_dot_)9020408(_at_)rock-chips(_dot_)com> Date: Fri, 17 Mar 2017 10:26:13 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <63969127-3fcd-658c-2986-8ded6d93c433(_at_)arm(_dot_)com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner(_at_)vger(_dot_)kernel(_dot_)org Precedence: bulk List-ID: X-Mailing-List: linux-kernel(_at_)vger(_dot_)kernel(_dot_)org X-Spam-Status: No, score=-5.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD autolearn=disabled version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mr2.cc.vt.edu X-Gm-Spam: 0 X-Gm-Phishy: 0 X-Gm-Spam: 0 X-Gm-Phishy: 0 在 2017年03月17日 00:18, Andre Przywara 写道: > Hi Chen, > > On 16/03/17 01:45, cl(_at_)rock-chips(_dot_)com wrote: >> From: Chen Liang >> >> This patch add rk3328-evb.dts for RK3328 evaluation board. >> Tested on RK3328 evb. >> >> Signed-off-by: Chen Liang >> --- >> arch/arm64/boot/dts/rockchip/Makefile | 1 + >> arch/arm64/boot/dts/rockchip/rk3328-evb.dts | 57 +++++++++++++++++++++++++++++ >> 2 files changed, 58 insertions(+) >> create mode 100644 arch/arm64/boot/dts/rockchip/rk3328-evb.dts >> >> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile >> index 3a86289..853fc7d 100644 >> --- a/arch/arm64/boot/dts/rockchip/Makefile >> +++ b/arch/arm64/boot/dts/rockchip/Makefile >> @@ -4,6 +4,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-orion-r68-meta.dtb >> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-px5-evb.dtb >> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-r88.dtb >> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-evb.dtb >> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-evb.dtb >> >> always := $(dtb-y) >> subdir-y := $(dts-dirs) >> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-evb.dts b/arch/arm64/boot/dts/rockchip/rk3328-evb.dts >> new file mode 100644 >> index 0000000..cf27239 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/rockchip/rk3328-evb.dts >> @@ -0,0 +1,57 @@ >> +/* >> + * Copyright (c) 2017 Fuzhou Rockchip Electronics Co., Ltd >> + * >> + * This file is dual-licensed: you can use it either under the terms >> + * of the GPL or the X11 license, at your option. Note that this dual >> + * licensing only applies to this file, and not this project as a >> + * whole. >> + * >> + * a) This library is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License as >> + * published by the Free Software Foundation; either version 2 of the >> + * License, or (at your option) any later version. >> + * >> + * This library is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * Or, alternatively, >> + * >> + * b) Permission is hereby granted, free of charge, to any person >> + * obtaining a copy of this software and associated documentation >> + * files (the "Software"), to deal in the Software without >> + * restriction, including without limitation the rights to use, >> + * copy, modify, merge, publish, distribute, sublicense, and/or >> + * sell copies of the Software, and to permit persons to whom the >> + * Software is furnished to do so, subject to the following >> + * conditions: >> + * >> + * The above copyright notice and this permission notice shall be >> + * included in all copies or substantial portions of the Software. >> + * >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, >> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES >> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND >> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT >> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, >> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING >> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR >> + * OTHER DEALINGS IN THE SOFTWARE. >> + */ >> + >> +/dts-v1/; >> +#include "rk3328.dtsi" >> + >> +/ { >> + model = "Rockchip RK3328 EVB"; >> + compatible = "rockchip,rk3328-evb", "rockchip,rk3328"; >> + >> + chosen { >> + stdout-path = "serial2:1500000n8"; > Is that really 1.5MBit/s? Yes, the RK3328 EVB board use 1.5MBit/s baud rate. > >> + }; >> +}; >> + >> +&uart2 { >> + status = "okay"; >> +}; > I don't have the board, but would expect to see more peripherals > mentioned in the .dtsi enabled here. > For sure the board has an (micro)SD card slot, possibly even Ethernet? The codes for other peripherals are not ready now for new kernel, so i push a base dtsi, and other configration will be pushed later if it is ok. > Cheers, > Andre. >