perl-unicode

Encode patch; more incodings & Encode::XX pod fix

2002-03-19 00:17:32
jhi,

  To more fixes to Encode.

* Encode.pm
iso-2022-jp and 7bit-jis are missing from external encodings. I think these two were dropped because the compile does not support ISO-2022 variants but I have already added Encode::JP::* to override this so it is safe to include them. CAVEAT: There is no general-purpose ISO-2022 module yet. I think the closest one to this is Encode::Tcl, however

* Encode::XX

  Pod example says

 $utf8   = encode("euc-jp", $euc_jp); # ditto

  This is obviously a bug so fixed as

 $utf8   = decode("euc-jp", $euc_jp); # ditto

I think this one is originated by me with Encode::JP then copied and pasted by others. Sorry.

Dan the Yet Another Encode Hacker

> diff -r -u Encode Encode.new | grep -v 'Only in'
diff -r -u Encode/CN/CN.pm Encode.new/CN/CN.pm
--- Encode/CN/CN.pm     Tue Mar 12 04:56:34 2002
+++ Encode.new/CN/CN.pm Tue Mar 19 16:03:37 2002
@@ -16,7 +16,7 @@

     use Encode 'encode';
     $euc_cn = encode("euc-cn", $utf8);   # loads Encode::CN implicitly
-    $utf8   = encode("euc-cn", $euc_cn); # ditto
+    $utf8   = decode("euc-cn", $euc_cn); # ditto

 =head1 DESCRIPTION

diff -r -u Encode/Encode.pm Encode.new/Encode.pm
--- Encode/Encode.pm    Mon Mar 18 06:14:57 2002
+++ Encode.new/Encode.pm        Tue Mar 19 16:01:41 2002
@@ -66,6 +66,8 @@
        cp936           => 'Encode/CN.pm',
        'iso-ir-165'    => 'Encode/CN.pm',
        'euc-jp'        => 'Encode/JP.pm',
+       'iso-2022-jp'   => 'Encode/JP.pm',
+       '7bit-jis'      => 'Encode/JP.pm',
        shiftjis        => 'Encode/JP.pm',
        macjapan        => 'Encode/JP.pm',
        cp932           => 'Encode/JP.pm',
diff -r -u Encode/JP/JP.pm Encode.new/JP/JP.pm
--- Encode/JP/JP.pm     Tue Mar 12 04:56:38 2002
+++ Encode.new/JP/JP.pm Tue Mar 19 16:02:57 2002
@@ -22,7 +22,7 @@

     use Encode 'encode';
     $euc_jp = encode("euc-jp", $utf8);   # loads Encode::JP implicitly
-    $utf8   = encode("euc-jp", $euc_jp); # ditto
+    $utf8   = decode("euc-jp", $euc_jp); # ditto

 =head1 ABSTRACT

diff -r -u Encode/KR/KR.pm Encode.new/KR/KR.pm
--- Encode/KR/KR.pm     Tue Mar 12 04:56:38 2002
+++ Encode.new/KR/KR.pm Tue Mar 19 16:04:12 2002
@@ -15,7 +15,7 @@

     use Encode 'encode';
     $euc_kr = encode("euc-kr", $utf8);   # loads Encode::KR implicitly
-    $utf8   = encode("euc-kr", $euc_kr); # ditto
+    $utf8   = decode("euc-kr", $euc_kr); # ditto

 =head1 DESCRIPTION

diff -r -u Encode/TW/TW.pm Encode.new/TW/TW.pm
--- Encode/TW/TW.pm     Tue Mar 12 04:56:38 2002
+++ Encode.new/TW/TW.pm Tue Mar 19 16:04:28 2002
@@ -15,7 +15,7 @@

     use Encode 'encode';
     $big5 = encode("big5", $utf8); # loads Encode::TW implicitly
-    $utf8 = encode("big5", $big5); # ditto
+    $utf8 = decode("big5", $big5); # ditto

 =head1 DESCRIPTION

<Prev in Thread] Current Thread [Next in Thread>