perl-unicode

[PATCH 5.8.1 @19053] Time::HiRes

2003-03-31 15:30:04
The test would emit a warning about a non-initialized variable.  (in a
maze of branches my system managed to find one where 'xdefine' file is
not written.)

I did not try to fix another goof (common for Time::HiRes and Encode):
they test for PERL_CORE using some hideous code.  *At least* the check for 
miniperl in the test should be //i.  But anyway:

 a) I could find no place which would *read* $ENV{PERL_CORE};

 b) The proper way to test for PERL_CORE is test @ARGV for PERL_CORE=1.

Thanks,
Ilya

--- ./ext/Time/HiRes/HiRes.t-pre        Sun Nov  3 22:34:36 2002
+++ ./ext/Time/HiRes/HiRes.t    Thu Mar 27 00:08:02 2003
@@ -30,7 +30,7 @@ import Time::HiRes 'ualarm'           if $have_ua
 
 use Config;
 
-my $xdefine; 
+my $xdefine = '';
 
 if (open(XDEFINE, "xdefine")) {
     chomp($xdefine = <XDEFINE>);

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH 5.8.1 @19053] Time::HiRes, Ilya Zakharevich <=