perl-unicode

Re: Patch for tests on un*x

2004-01-29 07:30:04
Brad Guillory <round(_at_)baileylink(_dot_)net> writes:
Last spring someone committed a patch to fix the tests on windows 
platforms (see Change 18966 by gsar(_at_)zen-gsar on 2003/03/14 04:20:51).  
This broke the tests on my Redhat box.  Here is a compromise patch:

--- t/enc_module.t.orig 2004-01-28 11:34:27.000000000 -0600
+++ t/enc_module.t      2004-01-28 11:34:42.000000000 -0600
@@ -54,7 +54,7 @@
 $obj = Mod_EUCJP->new;
 my $i = 0;
 while(<STDIN>){
-    s/\r?\n\z//;
+    s/\r?\n\z?//;

Unless I am more confused than I think I am an optional zero-width 
assertion is same as no assertion at all. 
So that is equivalent to s/\r?\n//
Was \z meant to be ^Z (DOS EOF marker)?


     is ($cmp[$i++], $_, "encoding vs. STDIN - $i");
 }

Also someone may want to put in the docs or in the fail report that 
LC_ALL must be set during "make test"

Thanks, BMG

<Prev in Thread] Current Thread [Next in Thread>