RE: performance with template and choose

It looks as if MSXML3 isn't clever enough to spot that the different
match patterns contain common subexpressions (e.g.

KH[(_at_)Type='401']/Key[(_at_)ProdID ='83' and translate(@StopVal, '-','')
&lt;='20050911']

and so it is evaluating this subexpression several times for each
candidate node. Your rewritten code avoids this by factoring out the
subexpression so that there is a two-stage test.

Saxon won't do this optimization either, though in 7.2 I've started to
put the logic in place to factor out common subexpressions.
Interestingly, in Saxon 7.2 you could do this yourself with a memo
function:

<xsl:template match="MD[z:type-1(.) and @ACPID='100']/@AAvl"

priority="1001" >



<xsl:function name="z:type-1" saxon:memo-function="yes">
  <xsl:param name="N"/>
  <xsl:return select=boolean($N/parent::Key[(_at_)ProdID ='83' and
translate(@StopVal, '-','') &lt;='20050911']/parent::KH[(_at_)Type='401'])"/>
</xsl:function>

If a memo function is called twice with the same arguments, it remembers
the result from the first time and avoids re-evaluating the function.

Michael Kay
Software AG
home: Michael(_dot_)H(_dot_)Kay(_at_)ntlworld(_dot_)com
work: Michael(_dot_)Kay(_at_)softwareag(_dot_)com

-----Original Message-----
From: owner-xsl-list(_at_)lists(_dot_)mulberrytech(_dot_)com 
[mailto:owner-xsl-list(_at_)lists(_dot_)mulberrytech(_dot_)com] On Behalf Of 
Kimberly Hahn
Sent: 11 September 2002 22:20
To: XSL-List(_at_)lists(_dot_)mulberrytech(_dot_)com
Subject: [xsl] performance with template and choose



I have a transformation that takes roughly 2.8 sec to run 
(using MSXML).  I
made some changes to it, moving some of the template matches 
into a choose
within a broader template.  This change was made for 
functional reasons, but
it cut the transformation time down to 1.4 sec.  I was just curious if
someone could shed light on why there was the performance improvement.

Sample differences:
slower version was structured as -
<xsl:template match="KH[(_at_)Type='401']/Key[(_at_)ProdID ='83' and
translate(@StopVal, '-','') &lt;='20050911']/MD[(_at_)ACPID='100']/@AAvl"
priority="1001" >
<xsl:attribute name="AAvl">1</xsl:attribute>
</xsl:template>
<xsl:template match="KH[(_at_)Type='401']/Key[(_at_)ProdID ='83' and
translate(@StopVal, '-','') &lt;='20050911']/MD[(_at_)BCPID='100']/@BAvl"
priority="1002" >
<xsl:attribute name="BAvl">1</xsl:attribute>
</xsl:template>
<xsl:template match="KH[(_at_)Type='401']/Key[(_at_)ProdID ='83' and
translate(@StopVal, '-','') &lt;='20030911']/MD[(_at_)ACPID='10']/@AAvl"
priority="1003" >
<xsl:attribute name="AAvl">1</xsl:attribute>
</xsl:template>
<xsl:template match="KH[(_at_)Type='401']/Key[(_at_)ProdID ='83' and
translate(@StopVal, '-','') &lt;='20030911']/MD[(_at_)BCPID='10']/@BAvl"
priority="1004" >
<xsl:attribute name="BAvl">1</xsl:attribute>
</xsl:template>
<xsl:template match="KH[(_at_)Type='401']/Key[(_at_)ProdID ='83' and
translate(@StopVal, '-','') &lt;='20030311']/MD[(_at_)ACPID='3']/@AAvl"
priority="1005" >
<xsl:attribute name="AAvl">1</xsl:attribute>
</xsl:template>
<xsl:template match="KH[(_at_)Type='401']/Key[(_at_)ProdID ='83' and
translate(@StopVal, '-','') &lt;='20030311']/MD[(_at_)BCPID='3']/@BAvl"
priority="1006" >
<xsl:attribute name="BAvl">1</xsl:attribute>
</xsl:template>

faster version as -
<xsl:template match="KH/Key[(_at_)ProdID ='83']/MD/@AAvl" priority="1001">
<xsl:attribute name="AAvl">
<xsl:choose>
<xsl:when test="translate(ancestor::Key/@StopVal, '-','') 
&lt;='20030311'
and (parent::MD/@ACPID='3')">1</xsl:when>
<xsl:when test="translate(ancestor::Key/@StopVal, '-','') 
&lt;='20030911'
and (parent::MD/@ACPID='10')">1</xsl:when>
<xsl:when test="translate(ancestor::Key/@StopVal, '-','') 
&lt;='20050911'
and (parent::MD/@ACPID='100')">1</xsl:when>
</xsl:choose>
</xsl:attribute>
</xsl:template>
<xsl:template match="KH/Key[(_at_)ProdID ='83']/MD/@BAvl" priority="1001">
<xsl:attribute name="BAvl">
<xsl:choose>
<xsl:when test="translate(ancestor::Key/@StopVal, '-','') 
&lt;='20030311'
and (parent::MD/@BCPID='3')">1</xsl:when>
<xsl:when test="translate(ancestor::Key/@StopVal, '-','') 
&lt;='20030911'
and (parent::MD/@BCPID='10')">1</xsl:when>
<xsl:when test="translate(ancestor::Key/@StopVal, '-','') 
&lt;='20050911'
and (parent::MD/@BCPID='100')">1</xsl:when>
</xsl:choose>
</xsl:attribute>
</xsl:template>

All other things (other named templates and unrelated 
template matches) in
the XSL documents were unchanged.


 XSL-List info and archive:  http://www.mulberrytech.com/xsl/xsl-list



 XSL-List info and archive:  http://www.mulberrytech.com/xsl/xsl-list