xsl-list
[Top] [All Lists]

Re: [xsl] Re: ANN: A static code quality tool, for XSLT code

2008-12-30 00:38:14
Hi Alain,
   Thanks for suggesting this rule. I feel it's a useful rule.

I have added this rule to the utility I posted, and have made changes
to the site.

You could test it, and let me know if it works fine ...

On Tue, Dec 30, 2008 at 12:41 AM, Alain <alainb06(_at_)free(_dot_)fr> wrote:
Hello Mukul,

congratulations, it's very nice and useful !

I don't know if it's considered "good practice" or not, but a trap I have
often gone into is this one.


<xsl:variable name="pass1">
<!--
    Some code for "Pass 1"
 -->
</xsl:variable>

<xsl:apply-templates match="pass1/foo"/>


The example is so simple here, it's quite obvious that what I meant was
probably

$pass1/foo

and not

pass1/foo

But of course the XSLT engine won't complain as the syntax is totally
correct.
It will apply templates on any matching pass1/foo child from the current
location... which generally won't match anything if you just forgot the $
sign !
So it's a very difficult typo to catch as everything runs smoothly but does
not produce the expected result.

And even if you write this code on purpose, it's a very confusion code, and
I'll find it hard to maintain (I mean naming a variable something and
matching nodes having the exact same name in the same context), you could
issue a "Warning" in such a case.

21. AreYouConfusingVariableAndNode

I suspect the template to trap that is not too complicated in respect to
what you already did !

Cheers
Alain.



-- 
Regards,
Mukul Gandhi

--~------------------------------------------------------------------
XSL-List info and archive:  http://www.mulberrytech.com/xsl/xsl-list
To unsubscribe, go to: http://lists.mulberrytech.com/xsl-list/
or e-mail: <mailto:xsl-list-unsubscribe(_at_)lists(_dot_)mulberrytech(_dot_)com>
--~--