On Tue, Jun 12, 2001 at 11:40:36 -0400, Eric S. Raymond wrote:
fetchmail-5.8.6 (Tue Jun 12 08:16:54 EDT 2001), 20676 lines:
* Add capability to insert poll trace data in the Received line.
The tracepolls option breaks RFC 822 as I read it. A fix could be
to put the trace information into the RFC 822 comment:
--- driver.c.org Wed Jun 13 18:35:13 2001
+++ driver.c Wed Jun 13 18:35:45 2001
@@ -1068,7 +1068,7 @@ static int readheaders(int sock,
* This header is technically invalid under RFC822.
* POP3, IMAP, etc. are not legal mail-parameter values.
*/
- sprintf(buf, "\tby %s with %s (fetchmail-%s)",
+ sprintf(buf, "\tby %s with %s (fetchmail-%s",
fetchmailhost,
protocol->name,
VERSION);
@@ -1078,7 +1078,7 @@ static int readheaders(int sock,
ctl->server.pollname,
ctl->remotename);
}
- strcat(buf, "\r\n");
+ strcat(buf, ")\r\n");
n = stuffline(ctl, buf);
if (n != -1)
{
Another thing: Information about the option --tracepolls is missing
in the output from 'fetchmail --help', but there is instead a
mention of the non-existing option --addaccthdr. May be a left-over
from the first take at the trace implemention?
Regards
Byrial