fetchmail-friends
[Top] [All Lists]

Re: [fetchmail][PATCH] Security fix for buffer overflow on rfc822.c(nxtaddr)

2001-06-19 18:15:47
On Tue, 12 Jun 2001, Henrique de Moraes Holschuh wrote:
Patch attached. Refers to Debian bug # 100394. This bug has been there
sleeping for a VERY long time... back to 5.5.3 at the very least (unless
some other code avoided calling nxtaddr in long headers back then... I
didn't check).

And of course, the code broke because of it. Please see #101530.

-#define HEADER_END(p)        ((p)[0] == '\n' && ((p)[1] != ' ' && (p)[1] != 
'\t'))
+#define HEADER_END(p)        ((p)[0] == '\n' && ((p)[1] != ' ' && (p)[1] != 
'\t' && (p)[1] != '\0'))

This needs to be backed out, or the multidrop code breaks. The rest of the
patch works.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh


<Prev in Thread] Current Thread [Next in Thread>