fetchmail-friends
[Top] [All Lists]

Re: [fetchmail][PATCH] general cleanup and anti-format-string patch

2001-06-24 14:56:49
On Sun, 24 Jun 2001, Todd Sabin wrote:
Henrique de Moraes Holschuh <hmh(_at_)debian(_dot_)org> writes:
and changes lots of sprintfs to snprintf. Same for strcat -> strncat.

Your usage of strncat is wrong.  Don't feel bad, though; nearly
everyone misuses it the same way.  strncat is one of the worst
designed apis in existence.  I'd suggest not using it at all.

Changed them all to snprintf, which is safe and quite easily understood.
Thanks for the hint, strncat won't get me unaware again.

Patch against 5.8.8 WITH my previous bogus patch applied. Attached.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Attachment: patch
Description: Text document