fetchmail-friends
[Top] [All Lists]

Re: [fetchmail]Small Bug in address parsing

2001-07-01 09:38:59
rohit , kumar hello(_at_)hurkle(_dot_)thyrsus(_dot_)com, 
<rohitk(_at_)whitepj(_dot_)com>:
Hi,
 I think there is small bug in the way address is being parsed.

Suppose the name is of the format   

abc , def" hello,\ 

Then the name sent is in the following format
"abc , def\" hello,\\"<email_address>
 
The fetchmail rewrites the From as
"abc , def\" hello(_at_)server,\\"<email_address>        

To correct it I think the following code should be modified :

File : rfc822.c
Function : reply_hack()

case2:

        if (*from == '"')
            /**************** Added By Rohit 
************************************************/
            if(*(from -1) != '\\' )
            {
                state = 1;
            }
            else
            {
                int i_count  = 0;
                int i = 1;
                while(*(from -i) == '\\')
                {
                    i++;
                    i_count++;
                }
                if(i_count % 2 == 0)
                {
                    state = 1;
                }
            }

        break;



Thanks And Regards
Rohit

Sorry, can you send this change as a diff?
-- 
                <a href="http://www.tuxedo.org/~esr/";>Eric S. Raymond</a>

The day will come when the mystical generation of Jesus by the Supreme
Being as his father, in the womb of a virgin, will be classed with the
fable of the generation of Minerva in the brain of Jupiter.
        -- Thomas Jefferson, 1823


<Prev in Thread] Current Thread [Next in Thread>