fetchmail-friends
[Top] [All Lists]

Re: [fetchmail]5.9.1 - 5.9.3 strange protocol warnings

2001-09-30 16:04:28
hmh(_at_)debian(_dot_)org <hmh(_at_)debian(_dot_)org>:
I think I nailed the thing down:
in fetchmail.c, between 5.9.0 and 5.9.3:
@@ -1394,60 +1291,77 @@
                break;
        }
        ctl->server.protocol = P_AUTO;
-       return(st);
     case P_POP2:
 #ifdef POP2_ENABLE
-       return(doPOP2(ctl));
+       st = doPOP2(ctl);

Notice how the program flow changes due to the now missing return(st)
clause. It should have been replaced by a break;  That (and other similar
changes in this place -- I haven't finished reviewing the diffs and will
attempt a fix in about 1h) is probably the source of the problem.

Eric, may I suggest huge intakes of coffee or strong tea before touching
such stuff?  Or maybe that rewrite to python ?  :)

I actually fixed these in 5.9.3.

But that Python rewrite is looking more tempting all the time...
-- 
                <a href="http://www.tuxedo.org/~esr/";>Eric S. Raymond</a>

"They that can give up essential liberty to obtain a little temporary 
safety deserve neither liberty nor safety."
        -- Benjamin Franklin, Historical Review of Pennsylvania, 1759.


<Prev in Thread] Current Thread [Next in Thread>