fetchmail-friends
[Top] [All Lists]

Re: [fetchmail]5.9.1 - 5.9.3 strange protocol warnings

2001-09-30 15:54:20
On Sun, 30 Sep 2001, Joshua Swink wrote:
Back at version 5.9.1 strange protocol warnings began to appear.  In 5.9.2
they were still there, but in 5.9.3 they have changed a little.  Here is the
output of a normal run when there is no mail for several recent versions:

I think I nailed the thing down:
in fetchmail.c, between 5.9.0 and 5.9.3:
@@ -1394,60 +1291,77 @@
                break;
        }
        ctl->server.protocol = P_AUTO;
-       return(st);
     case P_POP2:
 #ifdef POP2_ENABLE
-       return(doPOP2(ctl));
+       st = doPOP2(ctl);

Notice how the program flow changes due to the now missing return(st)
clause. It should have been replaced by a break;  That (and other similar
changes in this place -- I haven't finished reviewing the diffs and will
attempt a fix in about 1h) is probably the source of the problem.

Eric, may I suggest huge intakes of coffee or strong tea before touching
such stuff?  Or maybe that rewrite to python ?  :)

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh


<Prev in Thread] Current Thread [Next in Thread>