On Mon, 24 Dec 2001, ESR wrote:
Sunil Shetye <shetye(_at_)bombay(_dot_)retortsoft(_dot_)com>:
diff -Naur fetchmail-5.9.6.orig/imap.c fetchmail-5.9.6/imap.c
--- fetchmail-5.9.6.orig/imap.c Thu Nov 8 22:00:01 2001
+++ fetchmail-5.9.6/imap.c Sat Dec 22 10:35:33 2001
@@ -576,6 +576,7 @@
*newp = unseen;
expunged = 0;
+ deletions = 0;
return(PS_SUCCESS);
}
What put you on to this being necessary?
Eric, I also examined this patch, and I could not find a place where
deletions was properly initialized at all. Maybe I am dense at C, but at the
very least the current code is non-obvious if it is initializing deletions
IMHO... (the fact that other .c file use 'deletions' which is NOT the same
variable even if imap.c's is a static int global, does not help either).
See attached patch for something I am trying right now, and which (if it is
right) makes the code a easier to follow IMHO
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
foo
Description: Text document