fetchmail-friends
[Top] [All Lists]

[fetchmail] various fixes

2002-10-26 13:01:21
Here is a patch to various problems:

Problem 1: No auth fail note.

    If there is a series of authentication failures after a successful
    authentication, the auth fail note never gets sent. The problem is
    in this test:

((ctl->wehaveauthed && ++ctl->authfailcount == 10) || ++ctl->authfailcount == 3)

    The test runs currently as:

1st loop: ((1 &&  1 == 10) ||  2 == 3)
2nd loop: ((1 &&  3 == 10) ||  4 == 3)
3rd loop: ((1 &&  5 == 10) ||  6 == 3)
4th loop: ((1 &&  7 == 10) ||  8 == 3)
5th loop: ((1 &&  9 == 10) || 10 == 3)
6th loop: ((1 && 11 == 10) || 12 == 3)

Problem 2: Unexpected SIGALRM (reported by Rob Funk).

    If a pending alarm is delivered after the signal handler has been
    restored, fetchmail quits.

Problem 3: Memory leak. 

    host_fqdn() returns allocated memory. This is not freed by
    send_bouncemail().

    delivered_to line is not freed by readheaders() if it is not used.

Problem 4: Lines beginning with '\0'.

    If the first character of a line is '\0', stuffline() tries to
    look at the previous undefined character.

Problem 5: New configure warnings (no patch for this)

    The new configure script is generating some warnings. Probably,
    some more scripts need to be regenerated?

=================================================================
...

checking whether build environment is sane... yes
./missing: Unknown `--run' option
Try `./missing --help' for more information
configure: WARNING: `missing' script is too old or missing
checking for gawk... gawk

...

checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for shared library run path origin... ./config.rpath:
    ./config.rpath: No such file or directory
done
checking argz.h usability... yes

...
=================================================================

Sunil Shetye.

Attachment: fetchmail-6.1.1-various.patch
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>
  • [fetchmail] various fixes, Sunil Shetye <=