fetchmail-friends
[Top] [All Lists]

[fetchmail] Re: upgraded, driver.c patch...

2003-06-19 02:24:37
Quoting from Avinash Chopde's mail on Wed, Jun 18, 2003 at 12:51:01PM -0400:
So, the best way to try this will be for you to connect to my
email server - I've logs below that show the behavior (even with
the incorrect password for my POP email account) is different, 
so should help you try out more things faster...
------------------------------------------------------------------------
[without 
    sslproto ""
in .fetchmailrc]

$ fetchmail -v
fetchmail: 6.2.2 querying www.aczone.com (protocol POP3) at Wed Jun 18 
12:45:15
2003: poll started
fetchmail: POP3< +OK POP3 aczone.com v2001.78rh server ready
fetchmail: POP3> CAPA
fetchmail: POP3< +OK Capability list follows:
fetchmail: POP3< TOP
fetchmail: POP3< LOGIN-DELAY 180
fetchmail: POP3< UIDL
fetchmail: POP3< STLS
fetchmail: POP3< USER
fetchmail: POP3< SASL LOGIN
fetchmail: POP3< .
fetchmail: POP3> STLS
fetchmail: POP3< +OK STLS completed
fetchmail: POP3> CAPA
fetchmail: POP3> USER pop
fetchmail: POP3> PASS
fetchmail: Unknown login or authentication error on 
pop(_at_)www(_dot_)aczone(_dot_)com
fetchmail: POP3> QUIT
fetchmail: 6.2.2 querying www.aczone.com (protocol POP3) at Wed Jun 18 
12:45:15
2003: poll completed
fetchmail: Query status=15
fetchmail: normal termination, status 15
------------------------------------------------------------------------

Well, the exit status is still 15! So, the error must be elsewhere!

I feel the bug is now in the SSL code. Please try this patch. It is to
be applied after the previous patch.

The first part of this patch should not affect your case. It should
only matter when the capabilities are different after STLS.

Also, could someone comment on the call to ERR_print_errors_fp()? It
doesn't seem to be printing any error messages.

=========================================================================
diff -Naur fetchmail-6.2.2.orig/pop3.c fetchmail-6.2.2/pop3.c
--- fetchmail-6.2.2.orig/pop3.c 2003-06-19 13:50:45.000000000 +0530
+++ fetchmail-6.2.2/pop3.c      2003-06-19 14:32:46.000000000 +0530
@@ -146,6 +146,20 @@
 {
     int        ok;
 
+#if defined(GSSAPI)
+    has_gssapi = FALSE;
+#endif /* defined(GSSAPI) */
+#if defined(KERBEROS_V4) || defined(KERBEROS_V5)
+    has_kerberos = FALSE;
+#endif /* defined(KERBEROS_V4) || defined(KERBEROS_V5) */
+    has_cram = FALSE;
+#ifdef OPIE_ENABLE
+    has_otp = FALSE;
+#endif /* OPIE_ENABLE */
+#ifdef SSL_ENABLE
+    has_ssl = FALSE;
+#endif /* SSL_ENABLE */
+
     ok = gen_transact(sock, "CAPA");
     if (ok == PS_SUCCESS)
     {
diff -Naur fetchmail-6.2.2.orig/socket.c fetchmail-6.2.2/socket.c
--- fetchmail-6.2.2.orig/socket.c       2003-02-28 16:27:25.000000000 +0530
+++ fetchmail-6.2.2/socket.c    2003-06-19 13:56:31.000000000 +0530
@@ -932,7 +932,7 @@
 
        SSL_set_fd(_ssl_context[sock], sock);
        
-       if(SSL_connect(_ssl_context[sock]) == -1) {
+       if(SSL_connect(_ssl_context[sock]) < 1) {
                ERR_print_errors_fp(stderr);
                return(-1);
        }
=========================================================================

-- 
Sunil Shetye.

<Prev in Thread] Current Thread [Next in Thread>
  • [fetchmail] Re: upgraded, driver.c patch..., Sunil Shetye <=