mhonarc-dev

Re: wrong @ conversion in iso-2022-jp text

2003-02-18 21:53:42
Thank you for your quick reply as usual, Earl.

From: Earl Hood <earl(_at_)earlhood(_dot_)com>
Subject: Re: wrong @ conversion in iso-2022-jp text
Date: Fri, 14 Feb 2003 13:19:24 -0600
reported to me that v2.6.0 with iso2022jp.pl converts
Japanese text improperly.
...
The following diff should fix the problem:
...
Please test out the fix.

Umm, this patch seems inappropriate.

I think this

============================================================
-  '@'  => '&#x40;',
+  # '@'        => '&#x40;',  # XXX: Screws up ISO-2022-JP conversion
============================================================

should be

============================================================
-  '@'  => '&#x40;',
+  '@'  => '@',
============================================================

or

============================================================
diff -ur MHonArc2.6.0,orig/lib/ewhutil.pl MHonArc2.6.0/lib/ewhutil.pl
--- MHonArc2.6.0,orig/lib/ewhutil.pl    Sat Jan 18 11:57:34 2003
+++ MHonArc2.6.0/lib/ewhutil.pl Wed Feb 12 16:56:03 2003
@@ -52,7 +52,7 @@
     return ''  unless scalar(@_) && defined($_[0]);
     my $txt   = shift;
     my $txt_r = ref($txt) ? $txt : \$txt;
-    $$txt_r =~ s/(["&<>@])/$HTMLSpecials{$1}/g;
+    $$txt_r =~ s/(["&<>])/$HTMLSpecials{$1}/g;
     $$txt_r;
 }
 
============================================================

Otherwise, `@' will be disappeared.



By the way, I have a question concerning this.
I thought `@'s have been converted to &#x40; to avoid
address collecting (SPAM), haven't it?

So, it doesn't seem for me that this patch provides fundamental
solution.
In fact, the reason I said `I couldn't fix this problem' is
it's too tough (at least for me) to make MHonArc convert `@'
*ONLY* in ASCII text (and not in iso-2022-jp text).

Of course, I don't mean the patch is not acceptable.
I just want to confirm the reason why you converted `@' to
&#x40;.


Best regards,

-- 
Takashi P.KATOH

---------------------------------------------------------------------
To sign-off this list, send email to majordomo(_at_)mhonarc(_dot_)org with the
message text UNSUBSCRIBE MHONARC-DEV

<Prev in Thread] Current Thread [Next in Thread>