mhonarc-dev

[approved] [bugs #7571] <include> element doesn't look for resource files in $OUTDIR$

2004-03-15 20:16:15
This mail is an automated notification from the bugs tracker
 of the project: MHonArc.

/**************************************************************************/
[bugs #7571] Latest Modifications:

Changes by: 
                Earl Hood <earl(_at_)earlhood(_dot_)com>
'Date: 
                Mon 03/15/04 at 20:14 (US/Central)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Fixed
       Fixed Release |                           | CVS


------------------ Additional Follow-up Comments ----------------------------

There is a bug, but not what you think the bug is.
The looking into OUTDIR is only applicable for OTHERINDEXES
and not INCLUDE.

However, an attempt is to look in the same location the
resource file that is doing the including, which your
patch attempts to fix. But your patch will fail for cases
when $pathhead is empty.

A proper fix has been committed to CVS.







/**************************************************************************/
[bugs #7571] Full Item Snapshot:

URL: <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=7571>
Project: MHonArc
Submitted by: 0
On: Wed 02/04/04 at 01:32

Category:  Resources
Severity:  5 - Average
Item Group:  Incorrect Behavior
Resolution:  Fixed
Assigned to:  None
Status:  Open
Platform Version:  All
Perl Version:  5.8.0
Component Version:  2.6.8 (Perl 5.008 linux)
Fixed Release:  CVS


Summary:  <include> element doesn't look for resource files in $OUTDIR$

Original Submission:  IIUC, the intended behavior for <include> is to look for 
the resource files in $OUTDIR$ if no path is specified.  This doesn't work 
correctly due to a missing directory separator in mhrcfile.pl (example below).  
The attached patch fixes the issue.  Thanks.

Example -- the following won't include incfile.rc:

cd /
mkdir -p /tmp/mhonarctest
cat > /tmp/mhonarctest/rcfile.rc << EOF
<include>
incfile.rc
</include>
<title>
$BLAH$
</title>
EOF
cat > /tmp/mhonarctest/incfile.rc << EOF
<definevar>
BLAH
somevalue
</definevar>
EOF
mhonarc -add -rcfile rcfile.rc -outdir /tmp/mhonarctest mbox


Follow-up Comments
------------------


-------------------------------------------------------
Date: Mon 03/15/04 at 20:14         By: ehood

There is a bug, but not what you think the bug is.
The looking into OUTDIR is only applicable for OTHERINDEXES
and not INCLUDE.

However, an attempt is to look in the same location the
resource file that is doing the including, which your
patch attempts to fix. But your patch will fail for cases
when $pathhead is empty.

A proper fix has been committed to CVS.







File Attachments
-------------------

-------------------------------------------------------
Date: Wed 02/04/04 at 01:32  Name: include_outdir.patch  Size: 614KB   By: None
Patch to add a directory separator for include files
http://savannah.nongnu.org/bugs/download.php?item_id=7571&amp;item_file_id=1026






For detailed info, follow this link:
<http://savannah.nongnu.org/bugs/?func=detailitem&item_id=7571>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/


---------------------------------------------------------------------
To sign-off this list, send email to majordomo(_at_)mhonarc(_dot_)org with the
message text UNSUBSCRIBE MHONARC-DEV

<Prev in Thread] Current Thread [Next in Thread>
  • [approved] [bugs #7571] <include> element doesn't look for resource files in $OUTDIR$, Earl Hood <=