nmh-workers
[Top] [All Lists]

Re: [Nmh-workers] possibly missing fix in RC2

2003-09-12 20:30:04
Here is some additional info on this.  Does anyone see any problem with
my checking this in?

Thanks.

Jeff

--- Begin Message ---
The symptom is that the first ``inc'' into an empty folder will not
update the unseen sequence.  This is because seq_list() will return NULL
if mp->nummsg is zero.

My proposed fix follows.

Thanks.

Jeff

Index: uip/inc.c
===================================================================
RCS file: /master/contrib/nmh/uip/inc.c,v
retrieving revision 1.2
diff -u -r1.2 inc.c
--- uip/inc.c   2001/06/14 18:59:55     1.2
+++ uip/inc.c   2001/12/08 15:08:01
@@ -756,6 +756,7 @@
 
                msgnum++;
                mp->hghmsg++;
+               mp->nummsg++;
                clear_msg_flags (mp, msgnum);
                set_exists (mp, msgnum);
                set_unseen (mp, msgnum);

--- End Message ---
--- Begin Message --- Can you provide an example listing of nmh commands that show the problem so it can be verified as fixed after the patch is applied.

Shantonu

On Saturday, December 8, 2001, at 12:06 PM, Jeffrey C Honig wrote:

The symptom is that the first ``inc'' into an empty folder will not
update the unseen sequence.  This is because seq_list() will return NULL
if mp->nummsg is zero.

My proposed fix follows.

Thanks.

Jeff

Index: uip/inc.c
===================================================================
RCS file: /master/contrib/nmh/uip/inc.c,v
retrieving revision 1.2
diff -u -r1.2 inc.c
--- uip/inc.c   2001/06/14 18:59:55     1.2
+++ uip/inc.c   2001/12/08 15:08:01
@@ -756,6 +756,7 @@

                msgnum++;
                mp->hghmsg++;
+               mp->nummsg++;
                clear_msg_flags (mp, msgnum);
                set_exists (mp, msgnum);
                set_unseen (mp, msgnum);




--- End Message ---
--- Begin Message ---
Can you provide an example listing of nmh commands that show the problem 
so it can be verified as fixed after the patch is applied.

Assuming that you have a mail message in ``+inbox 1'' and your
.mh_profile contains ``Unseen-Sequence: unseen''.

         folder +test
         rmm all
         inc -file ~/Mail/inbox/1 +test
         scan unseen +test

Thanks.

Jeff

         

--- End Message ---

-- 
Jeffrey C. Honig <jch(_at_)honig(_dot_)net>
http://www.honig.net/jch
GnuPG ID:14E29E13 <http://www.honig.net/jch/key.shtml>
_______________________________________________
Nmh-workers mailing list
Nmh-workers(_at_)nongnu(_dot_)org
http://mail.nongnu.org/mailman/listinfo/nmh-workers
<Prev in Thread] Current Thread [Next in Thread>