nmh-workers
[Top] [All Lists]

Re: [Nmh-workers] Another questionable piece of code

2005-05-18 05:57:15
Jon Steinhart <jon(_at_)fourwinds(_dot_)com> wrote:

There's a pretty strange function called context_foil().  In all
but two of the places where it is called it is called with a NULL
argument so it does nothing except set the globals defpath and
context to "/dev/null", and none of these calling programs ever
reference these globals.

But other files in sbr do.  This function appears to cause the
.mh_profile and context file to be ignored by some functions.  Unless
MHCONTEXT and/or MH are set in the environment.

In post.c, if LIBSW is passed, a dummy context is set up with just a
Path: entry.

So it seems to me that these calls are bogus and can be removed.

Not at all.

Are you using cscope?  You should be using a tool like it to check for
side effects.  I'm sure there are many in the sbr/ directory.

Thanks.

Jeff

-- 
Jeffrey C. Honig <jch(_at_)honig(_dot_)net>
http://www.honig.net/jch
GnuPG ID:14E29E13 <http://www.honig.net/jch/key.shtml>


_______________________________________________
Nmh-workers mailing list
Nmh-workers(_at_)nongnu(_dot_)org
http://lists.nongnu.org/mailman/listinfo/nmh-workers

<Prev in Thread] Current Thread [Next in Thread>