nmh-workers
[Top] [All Lists]

Re: [Nmh-workers] m_getfld() interface

2012-12-25 11:59:17
I wrote:

1) Changed type of name argument from unsigned char * to
   unsigned char[NAMESZ].

2) Changed msg_style and msg_delim to be file static.

3) Change bufsz to be in-out instead of in, and therefore
   int * instead of int, and use that instead of global
   msg_count.

I created an m_getfld branch and made those changes.

Then for fun, I replaced all that stdio buffer nastiness in
m_getfld.c with a single call to fread() and then some
almost straightforward buffer manipulations.  It passes the
test suite and seems to perform the same (even 1-2% percent
faster), so I committed to the branch.

There are plenty of ways to improve what's there, but I
think this is a step forward and doesn't give up anything.
Needlesstosay, it needs to be reviewed.

David

_______________________________________________
Nmh-workers mailing list
Nmh-workers@nongnu.org
https://lists.nongnu.org/mailman/listinfo/nmh-workers

<Prev in Thread] Current Thread [Next in Thread>