nmh-workers
[Top] [All Lists]

Re: [PATCH] Make test-mhical pass with BSD yacc.

2020-09-20 10:53:20
Ralph wrote:

it could be like some of the other tests and grep directly.  Something
like

    check "$expected" "$actual"
    re='mhical: syntax error.* " this line is not folded"'
    grep -q "$re" "$actual_err"
    grep -qv "$re" "$actual_err" | grep -q ^ && false

or

    test `wc -l <"$actual_err"` -eq 1

I just committed a fix using that approach.  Thanks, Eric and Ralph.

Anyone here know why the printf a little earlier is wrapped in
set +e...set -e?  Perhaps something to do with the lack of trailing LF?

Good catch.  The test author assumed that the exit status from mhical(1)
would reflect the parse failure.  It didn't, but I just committed a fix
for that.

David


<Prev in Thread] Current Thread [Next in Thread>