[PATCH] Encoder.pm

Dan-san,

Here's a quick patch for Encode::Encoder. Just an obvious one ;)

In addition, what I want to discuss is encoder() function, which is
just a short cut for Encoder->new(). Yep, I notice this is a rip-off
from your Jcode module's jcode() function, which is a shortcut for
Jcode->new().

Well, I'm opposed to making this encoder() function into
@EXPORT. People use Encode::Encoder, just because they like OOP ;), so
they don't need encoder() short-cut, IMHO.


--- Encoder.pm.orig     Thu Apr 11 04:10:47 2002
+++ Encoder.pm  Thu Apr 11 04:11:50 2002
@@ -34,7 +34,7 @@
 sub encoder{ __PACKAGE__->new(@_) }

 sub data{
-    my ($self, $data) = shift;
+    my ($self, $data) = @_;
     if (defined $data){
        $self->{data} = $data;
        return $data;


-- 
Tatsuhiko Miyagawa <miyagawa(_at_)edge(_dot_)co(_dot_)jp>