perl-unicode

Re: Change 16308: Encode tweak from Dan Kogai.

2002-05-02 00:07:52
On Thursday, May 2, 2002, at 03:03 , Philip Newton wrote:
On Wed, 1 May 2002 09:45:05 -0700, jhi(_at_)iki(_dot_)fi (Jarkko Hietaniemi) 
wrote:

                if (check & ENCODE_DIE_ON_ERR) {
                    Perl_croak(
-                       aTHX_ "\"\\N{U+%" UVxf "}\" does not map to %s",
+ aTHX_ "\"\\x{%04" UVxf "}\" does not map to %s",
                        (UV)ch, enc->name[0]);
                    return &PL_sv_undef; /* never reaches but be safe */
                }
                if (check & ENCODE_WARN_ON_ERR){
                    Perl_warner(aTHX_ packWARN(WARN_UTF8),
-                               "\"\\N{U+%" UVxf "}\" does not map to %s",
+ "\"\\x{%" UVxf "}\" does not map to %s",
                                (UV)ch, enc->name[0]);
                }

Shouldn't the formats match? That is, both '% UVxf' or both '%04 UVxf'?
(I would probably tend to '%04 UVxf', FWIW, since I consider \x{03c0} to
be "nicer" than \x{3c0} -- since I'm accustomed to four-char codepoints
in the Unicode book.)

Right.  Will be fixed.

Dan

<Prev in Thread] Current Thread [Next in Thread>