fetchmail-friends
[Top] [All Lists]

Re: [fetchmail]Again: Patch for not-in-dns bug (debian bug #99197)

2001-07-01 09:58:42
Gerd v. Egidy <egidy(_at_)deam(_dot_)de>:
on june 19th I wrote a message to this list with a patch for a bug where
fetchmail quits directly after startup if one of the servers to poll is
not in dns ("couldn't find canonical DNS name of xxx").

Henrique later wrote that this is tracked as debian bug #99197.

But the patch in his follow-up mail on the list doesn't fix this bug but
others (general cleanup and anti-format-string patch).

And the newest 5.8.10 release doesn't contain my bugfix either.

Eric, would you please review my patch and include it in the next release.

Thank you.

Regards,

Gerd
diff -r -u fetchmail-5.8.7.orig/fetchmail.c fetchmail-5.8.7/fetchmail.c
--- fetchmail-5.8.7.orig/fetchmail.c  Sun Jun 17 16:11:29 2001
+++ fetchmail-5.8.7/fetchmail.c       Tue Jun 19 14:36:23 2001
@@ -1159,7 +1159,8 @@
                      report(stderr,
                             _("couldn't find canonical DNS name of %s\n"),
                             ctl->server.pollname);
-                     exit(PS_DNS);
+                     ctl->server.truename = xstrdup(ctl->server.queryname);
+                     ctl->server.trueaddr = NULL;
                  }
                  else {
                      ctl->server.truename=xstrdup((char *)namerec->h_name);

I'm having a design-philosophy problem with this.  When fetchmail fails, I
want it to fail noisily so the responsible persion can notice and fix the
problem.  Your change would make it fail invisibly when running in background
(which I consider the important case).
-- 
                <a href="http://www.tuxedo.org/~esr/";>Eric S. Raymond</a>

A right is not what someone gives you; it's what no one can take from you. 
        -- Ramsey Clark


<Prev in Thread] Current Thread [Next in Thread>