[fetchmail] [PATCH] fixing APOP with 6.2.5

Following up Kai Raven's messages of 17 Oct 2003, "no apop with 6.2.5".

The APOP problem was introduced between 6.2.4 and 6.2.5, with the
introduction of the fetchsizelimit variable.

The fetchsizelimit variable is forced to 1 for POP3 but not for APOP,
and otherwise defaults to 100.  For APOP, if there are at least 2 messages
to be fetched, pop3_getpartialsizes() will then be called with a range of
messages instead of a single message, generating the error Kai described.

Here is a patch which fixes this problem.  Kai's workaround of setting
fetchsizelimit 0 in .fetchmailrc works too, of course.

diff -ur fetchmail-6.2.5/driver.c fetchmail-6.2.5.mod/driver.c
--- fetchmail-6.2.5/driver.c    Wed Oct 15 21:22:31 2003
+++ fetchmail-6.2.5.mod/driver.c        Sun Oct 26 10:27:05 2003
@@ -429,7 +429,8 @@
        /* for POP3, we can get the size of one mail only! Unfortunately, this
         * protocol specific test cannot be done elsewhere as the protocol
         * could be "auto". */
-       if (ctl->server.protocol == P_POP3)
+       if ((ctl->server.protocol == P_POP3) ||
+           (ctl->server.protocol == P_APOP))
            fetchsizelimit = 1;
 
        /* Time to allocate memory to store the sizes */

-- Andras Salamon                   andras(_at_)dns(_dot_)net