ietf-openpgp
[Top] [All Lists]

Re: [openpgp] I-D Action: draft-ietf-openpgp-crypto-refresh-02.txt (fwd)

2021-02-28 12:12:27
On Fri, 26 Feb 2021, Daniel Kahn Gillmor wrote:

-    09 k0 k1 ... k31 c0 c1 05 05 05 05 05
+    09 k0 k1 ... k31 C0 C1 05 05 05 05 05

-The octets c0 and c1 above denote the checksum.
+The octets C0 and C1 above denote the checksum.

This seems like a mistake.  C0 and C1 could be specific hexadecimal
octets (decimal 12), whereas "c0" and "c1" here are intended to be
placeholders for the checksum.  This is a bit confusing, maybe it would
be better to use s0 and s1 (s for "sum") so that it's clear that it
isn't hex?

I like the idea of using s0 and s1.

I've included this proposal (without the two changes above that i think
are mistaken) and your other remark about the big-endianness of the
two-octet scalar in a merge request:

  https://gitlab.com/openpgp-wg/rfc4880bis/-/merge_requests/38

I encourage people to make merge requests directly in gitlab in addition
to posting patches to the mailing list, especially for
non-substantive/editorial changes like this.

Although please also comment on the list, so the editors can use that
to determine consensus, and importantly, any AD later on can read the
mail archive to verify any contentious consensus claim.

Paul

_______________________________________________
openpgp mailing list
openpgp(_at_)ietf(_dot_)org
https://www.ietf.org/mailman/listinfo/openpgp

<Prev in Thread] Current Thread [Next in Thread>