Hi,
Adding a little on two points:
On Sun, Aug 30, 2015 at 11:54 PM, Mingui Zhang
<zhangmingui(_at_)huawei(_dot_)com> wrote:
Hi Russ,
Thanks for the comments. Please see the in-lines below.
-----Original Message-----
From: Russ Housley [mailto:housley(_at_)vigilsec(_dot_)com]
Sent: Friday, August 28, 2015 5:59 AM
...
Document: draft-ietf-trill-pseudonode-nickname-05
Reviewer: Russ Housley
Review Date: 2015-08-24
IETF LC End Date: 2015-09-01
IESG Telechat date: unknown
Summary: Almost Ready
Major Concerns:
...
...
(2) Also, in Section 5.2, Step 1, I think the intended sort order depends
on all
of the LAALP IDi values being represented with the same number of bits.
Since Section 9.1 provides a variable length field to carry a LAALP ID
value, I
assume that they are not always the same length. Is a step needed to
encode the LAALP ID to a consistent length?
[MZ] The sort is done in the per-LAALP base. It's not necessary to make the
LAALP ID to a constant length. Besides, the 'mod' function always returns a
value in [0, k-1] whatever the length of LAALP ID is.
We could add "considering System ID and LAALP ID as byte strings".
...
...
Minor Concerns:
(1) ...
...
(2) I found the last sentence of Section 2 confusing. I am suggesting a
rewording to see if I figured it out. If I did not figure it out properly,
then the
sentence really does need to be reworked.
Under the assumption that the default learning is enabled at
edge RBridges, MAC flip-flopping can be solved by using a
Virtual RBridge together with its pseudo-nickname. This
document specifies a way to do so.
[MZ] Yes, this is clear. Will be incorporated.
Suggest: "Assuming that the default data-plane learning is enabled at
edge RBridges, MAC flip-flopping can be solved by using a Virtual
RBridge together with its psuedo-nickname. This document specifies a
way to do so."
...
...
...
Thanks,
Donald
=============================
Donald E. Eastlake 3rd +1-508-333-2270 (cell)
155 Beaver Street, Milford, MA 01757 USA
d3e3e3(_at_)gmail(_dot_)com
Thanks,
Mingui