[Nmh-workers] about mhparam

Hoi,

when I had a look at mhparam weeks ago I came about some stuff which I
like to share. It's minor but better mentioned than forgotten.


I improved the man page in some ways; see attached patch.


I also spotted code that appears to be badly formated:
--- a/uip/mhparam.c
+++ b/uip/mhparam.c
@@ -148,7 +148,9 @@ main(int argc, char **argv)
        for (np = m_defs; np; np = np->n_next)
            printf("%s: %s\n", np->n_name, np->n_field);
 
-    } if (debug) {
+    }
+
+    if (debug) {
        struct proc *ps;
 
        /*


Further more I wondered why mhparam has no default action. -all could
be set if mhparam is called without arguments. Another possibility
would be to print the default values from
    static struct proc procs []
in this case. Maybe there are reasons for the existing behavior.

The array procs may also miss some entries; `inbox' for instance.
Should we diff the list with man/mh-profile.man? What entries should
it include? All those ``not-so constants'' from config/config.c?
Should
    char *defaultfolder = "inbox";
then better be filed as a not-so constant?


As I don't have time to go for this stuff currently and as you know
about reasons better than I, I just hand this over to you. ;-)


meillo

diff --git a/man/mhparam.man b/man/mhparam.man
index eb8caec..678e41a 100644
--- a/man/mhparam.man
+++ b/man/mhparam.man
@@ -3,7 +3,7 @@
 .\"
 .TH MHPARAM %manext1% "%nmhdate%" MH.6.8 [%nmhversion%]
 .SH NAME
-mhparam \- print nmh profile components
+mhparam \- print nmh profile and context components
 .SH SYNOPSIS
 .na
 .B mhparam
@@ -62,6 +62,10 @@ rmmproc: rmmproc
 % mhparam \-nocomponent AliasFile rmmproc
 aliases
 rmmproc
+
+% mhparam path nonexistent context
+Path: Mail
+context: context
 .fi
 .RE
 .PP
@@ -74,12 +78,26 @@ is also useful in back\-quoted operations:
 .fi
 .RE
 .PP
+.B Mhparam
+exits with the number of components not found.
+.PP
 
 .SH FILES
 .fc ^ ~
 .nf
 .ta \w'%etcdir%/ExtraBigFileName  'u
-^$HOME/\&.mh\(ruprofile~^The user profile
+^$HOME/.mh_profile~^The user profile
+^or $MH~^Rather than the standard profile
+^<mh-dir>/context~^The user context
+^or $MHCONTEXT~^Rather than the standard context
+.fi
+
+.SH "PROFILE COMPONENTS"
+.fc ^ ~
+.nf
+.ta 2.4i
+.ta \w'ExtraBigProfileName  'u
+^context:~^To determine the context file
 .fi
 
 .SH "SEE ALSO"
diff --git a/uip/mhparam.c b/uip/mhparam.c
index 19f418e..d8bc74c 100644
--- a/uip/mhparam.c
+++ b/uip/mhparam.c
@@ -148,7 +148,9 @@ main(int argc, char **argv)
        for (np = m_defs; np; np = np->n_next)
            printf("%s: %s\n", np->n_name, np->n_field);
 
-    } if (debug) {
+    }
+
+    if (debug) {
        struct proc *ps;
 
        /*

_______________________________________________
Nmh-workers mailing list
Nmh-workers(_at_)nongnu(_dot_)org
http://lists.nongnu.org/mailman/listinfo/nmh-workers