nmh-workers
[Top] [All Lists]

Re: [Nmh-workers] Big patch: Add XOAUTH2 support for SMTP and POP

2016-03-13 14:28:15
Resurrecting the "unresolved issues" section of this :)

On Fri, Dec 5, 2014 at 6:07 PM, Eric Gillespie <epg(_at_)pretzelnet(_dot_)org> 
wrote:

Unresolved issues:

- mhlogin name / flag names

  Naming is hard :).  I picked this on the theory that it's not
  terribly confusing as is, and if there were to be some other
  kind of system users might need to login to, expanding mhlogin
  to have more than just -oauth would make sense.

I think we decided my names were ok? I don't mind at all if someone
wants to change them now.

- Repeating -user for each command is possibly odd.  Maybe put
  -user on mhlogin and save it in the cred file.  Arguably easier
  -for the user this way, arguably not.  Changing it would
  -complicate the code slightly.  I don't really care either way.

As I said, this would complicate the code, and I'm not  really sure
it's worth it. So you have -user foo repeated on a few lines in
.mh_profile, so what?

- I have a lot of test cases in only a few broadly categorized
  test scripts, and they print descriptions as they go so it's
  easy to see what broke.  This messes up the test suite output.
  Does this make sense, should I change this only to print only
  if some environment variable is set, or should I just break
  these up into one test case per script?  I'd kinda prefer the
  latter, but I don't know if anyone objects to a big pile of
  test scripts in there.

I thought someone had a suggestion for this, but just now I looked for
it and didn't find it.

- Owning the Google client credentials.  I took the liberty of
  creating a Google developer project for nmh already.  I'm happy
  to share ownership, or just give it away, or dispose of mine in
  favor of another.  I would suggest that the Google project have
  at least two owners.

Right :)

Also, I never did figure out what to do about different error messages
on different platforms. I work on FreeBSD and Linux and they were
different; never mind what other platforms look like...

Todos suggested by David:

To do:

* add "mhparam oauth" support
* add libcurl and libcurl-devel (on Linux) to MACHINES
* add reference to jsmn LICENSE to COPYRIGHT

Thanks.

_______________________________________________
Nmh-workers mailing list
Nmh-workers(_at_)nongnu(_dot_)org
https://lists.nongnu.org/mailman/listinfo/nmh-workers

<Prev in Thread] Current Thread [Next in Thread>