[Top] [All Lists]

Re: cleartext signatures - trailing white space - proposal

2004-03-12 08:38:04

On Fri, Mar 12, 2004 at 03:56:50PM +0100, Werner Koch wrote:

On Fri, 12 Mar 2004 08:31:16 -0500, Ian Grigg said:

The issue comes when you get files that are garbled
in their line endings:

    line< ><CR><CR><LF>

Our lineending is <CR><LF> and thus I would remove the space and the
first <CR>.


1. Determine the length of the line (according to the convention of
   the system the application runs).  
2. Trim trailing whitespace;  including CR and LF.
3. Append CR,LF
4. Hash the line

I strongly agree with this.  The whole point of trimming whitespace in
cleartext signatures is to protect the signature from accidental
whitespace damage via email and cut and paste and the like.  Leaving
any whitespace at the end of the line sort of defeats that point.

We can perhaps discuss what characters count as whitespace, but I
think that all of them should be removed.