nmh-workers
[Top] [All Lists]

Re: [Nmh-workers] strncpy(3), die, die, die.

2016-10-29 11:22:40
   strncpy(sm_reply.text, str, sizeof(sm_reply.text));
   sm_reply.text[sizeof(sm_reply.text) - 1] = '\0';

If this is what I think it is ... you know, I think this truncation is
benign.

There are a number of cases where we are getting a error message from,
say, an SMTP server and display it to the user.  In that case, I think
truncating a displayed error message is perfectly fine and should not
result in an abort().  I believe when I wrote netsec that all error
messages are returned in allocated memory so that shouldn't be an issue,
but changing all of the callers of it was too big of a job.

--Ken

_______________________________________________
Nmh-workers mailing list
Nmh-workers(_at_)nongnu(_dot_)org
https://lists.nongnu.org/mailman/listinfo/nmh-workers

<Prev in Thread] Current Thread [Next in Thread>