nmh-workers
[Top] [All Lists]

Re: [Nmh-workers] mhstore dumps core

2017-08-18 22:44:04
Ken wrote:

And dang, coming up with a test for the url external-body type is going
to be a pain.

Uh, yeah.  I fixed it and now valgrind doesn't report any problems.

David, do you recall why the clang static analyzer was complaining about
that?  Also, if you look in all the callers of openExternal() they only
use the "fd" argument if openExternal returns DONE.

Yes, but those callers return fd.  In this case, there was a path
for output_content_file() in mhstoresbr.c to read its value without
being it having been initialized.  valgrind noticed, too.

Thanks, Norm and Ken.

David

_______________________________________________
Nmh-workers mailing list
Nmh-workers(_at_)nongnu(_dot_)org
https://lists.nongnu.org/mailman/listinfo/nmh-workers

<Prev in Thread] Current Thread [Next in Thread>