procmail
[Top] [All Lists]

Re: INCLUDERC

2004-03-13 00:29:57
Robert Allerstorfer wrote:

  * $ ?"$TEST -r $my_INCLUDEFILE"

I still don't see why you're enclosing the command string in quotes and then using an extra dollar modifier to undo them instead of simply doing neither. It's like going up one flight of stairs and then down one flight to get to another room on the same floor of the building instead of just walking along the hall.

You're doing all this in the name of the possible greater efficiency of using /usr/bin/test instead of calling /bin/sh to use its test built-in. But then you add a layer of quoting and remove it instead of just leaving it off. Sounds like spending EUR20 to save EUR15.

Again, it's enough to use

 * ? $TEST -r $my_INCLUDEFILE

or heck, you also might as well hard-code /usr/bin/test and not waste the environment handling on a variable for it.


_______________________________________________
procmail mailing list
procmail(_at_)lists(_dot_)RWTH-Aachen(_dot_)DE
http://MailMan.RWTH-Aachen.DE/mailman/listinfo/procmail

<Prev in Thread] Current Thread [Next in Thread>