fetchmail-friends
[Top] [All Lists]

[fetchmail]Re: The 5.7.1 release of fetchmail is available

2001-03-04 02:19:47
On Sun, Mar 04, 2001 at 12:51:36AM -0500, Eric S. Raymond wrote:
The 5.7.1 release of fetchmail is now available at the usual locations,
including <URL:http://www.tuxedo.org/~esr/fetchmail>.

Here are the release notes:

fetchmail-5.7.1 (Sun Mar  4 00:30:04 EST 2001), 20167 lines:

* Note: NLS build ability is broken!
* FreeBSD port fixes.
* Man page polished and updated.
* Added --sslproto option from Peter Hedwig.
* Fix KPOP support, which got broken in 5.6.8. Closes Debian bug #88288.

NLS build is broken, and I am pissed off.  

I believe NLS is fixed now - at least it works here, on FreeBSD 4.2-STABLE.

However, there are a couple of other problems with 5.7.1, some of which
seem to have been languishing there for some time.  Attached is a patch
for some of them; I think there might be more of the NULL server.service
omitted checks.

G'luck,
Peter

-- 
I am jealous of the first word in this sentence.

Index: fetchmail/imap.c
===================================================================
RCS file: /home/cvsroot/roam/c/contrib/net/fetchmail/imap.c,v
retrieving revision 1.1.1.2
diff -u -r1.1.1.2 imap.c
--- fetchmail/imap.c    2001/03/02 13:36:33     1.1.1.2
+++ fetchmail/imap.c    2001/03/04 09:05:26
@@ -330,7 +330,7 @@
     if ((ctl->server.authenticate == A_ANY 
         || ctl->server.authenticate==A_OTP)
        && strstr(capabilities, "AUTH=X-OTP"))
-       return(do_otp(sock, ctl));
+       return(do_otp(sock, "AUTHENTICATE", ctl));
 #else
     if (ctl->server.authenticate==A_NTLM)
     {
Index: fetchmail/opie.c
===================================================================
RCS file: /home/cvsroot/roam/c/contrib/net/fetchmail/opie.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 opie.c
--- fetchmail/opie.c    2001/03/02 07:33:46     1.1.1.1
+++ fetchmail/opie.c    2001/03/04 09:05:26
@@ -17,12 +17,13 @@
 #include  "i18n.h"
 #include "md5.h"
 
-#if OPIE_ENABL
+#if OPIE_ENABLE
 #include <opie.h>
 
 int do_otp(int sock, char *command, struct query *ctl)
 {
     int i, rval;
+    int result;
     char buffer[128];
     char challenge[OPIE_CHALLENGE_MAX+1];
     char response[OPIE_RESPONSE_MAX+1];
Index: fetchmail/pop3.c
===================================================================
RCS file: /home/cvsroot/roam/c/contrib/net/fetchmail/pop3.c,v
retrieving revision 1.1.1.2
diff -u -r1.1.1.2 pop3.c
--- fetchmail/pop3.c    2001/03/04 08:08:26     1.1.1.2
+++ fetchmail/pop3.c    2001/03/04 09:05:26
@@ -195,7 +195,7 @@
 #endif /* defined(KERBEROS_V4) || defined(KERBEROS_V5) */
            flag has_cram = FALSE;
 #ifdef OPIE_ENABLE
-           flag has_opie = FALSE;
+           flag has_otp = FALSE;
 #endif /* OPIE_ENABLE */
            char buffer[64];
 
@@ -227,7 +227,7 @@
            if (has_cram)
                ctl->server.authenticate = A_CRAM_MD5;
 #ifdef OPIE_ENABLE
-           if (has_opie)
+           if (has_otp)
                ctl->server.authenticate = A_OTP;
 #endif /* OPIE_ENABLE */
 #if defined(GSSAPI)
@@ -250,7 +250,7 @@
         */
        if (
 #if INET6_ENABLE
-           strcmp(ctl->server.service, KPOP_PORT)!=0
+           ctl->server.service && (strcmp(ctl->server.service, KPOP_PORT)!=0)
 #else /* INET6_ENABLE */
            ctl->server.port != KPOP_PORT
 #endif /* INET6_ENABLE */
@@ -265,7 +265,7 @@
 #endif /* defined(GSSAPI) */
 #ifdef OPIE_ENABLE
        if (ctl->server.authenticate == A_OTP)
-           do_otp(sock, "AUTH", ctl)
+           do_otp(sock, "AUTH", ctl);
 #endif /* OPIE_ENABLE */
        if (ctl->server.authenticate == A_CRAM_MD5)
            return(do_cram_md5(sock, "AUTH", ctl));
Index: fetchmail/socket.h
===================================================================
RCS file: /home/cvsroot/roam/c/contrib/net/fetchmail/socket.h,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 socket.h
--- fetchmail/socket.h  2001/03/02 07:33:47     1.1.1.1
+++ fetchmail/socket.h  2001/03/04 09:05:26
@@ -59,7 +59,7 @@
 int SockClose(int sock);
 
 #if SSL_ENABLE
-int SSLOpen(int sock, char *mycert, char *mykey, char *servercname);
+int SSLOpen(int sock, char *mycert, char *mykey, char *myproto, char 
*servercname);
 #endif /* SSL_ENABLE */
 
 #endif /* SOCKET__ */