fetchmail-friends
[Top] [All Lists]

Re: [fetchmail]The 5.9.12 release of fetchmail is available

2002-06-06 08:23:13
Jason Tishler <jason(_at_)tishler(_dot_)net>:
Nevertheless, thanks for your patch.  Yours is "better" because it removes
the code duplicate between the SSL and non-SSL cases.  My second version
is "better" because it minimizes perturbing the existing code base.

Maybe a combination of the two would be best?

    o elimination of code duplication (from yours)
    o use of cygwin_read (via #def fm_read) to hide the Cygwin Winsock
      workaround (from mine)

Eric,

Do you have any opinions on what is the best approach?  Also, would
you consider one of these patches for inclusion in 6.0.0 (or 5.9.13)?
Or, should I resubmit after 6.0.0?

This sounds like it qualifies as a bug fix.  I'll cheerfully take a combined
patch for 6.0.0.
-- 
                <a href="http://www.tuxedo.org/~esr/";>Eric S. Raymond</a>